Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: What happens if amiParametersToTags contains used config? #397

Closed
wants to merge 1 commit into from

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Nov 16, 2023

Test to see what happens when amiParametersToTags includes an string that not present as a parameter in the CloudFormation template.

@akash1810
Copy link
Member Author

akash1810 commented Nov 16, 2023

This yields the following error when being deployed:

java.lang.RuntimeException User specified parameters that are not in template: NotUsed. Ensure that you are not specifying a parameter directly or as an AMI parameter.

It looks like Riff-Raff doesn't do any validation and passes all parameters to CloudFormation. It is CloudFormation that is (correctly) throwing the above error.

Fixing this might require Riff-Raff to parse the CloudFormation template file, or catch the thrown exception and retry.

@akash1810 akash1810 closed this Nov 16, 2023
@akash1810 akash1810 deleted the aa/amiParametersToTags-test branch November 16, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant